[BUG REPORT] Crashed my Android app

[LordBredit]

Hello, for some reason after a little changes my android game immediately crashes whenever i make jump event to another frame. I really don't know why is it happening but same events has almost every frame, but some frames crashes whenever i do jump
Screenshot_2022-06-30-21-32-26-217_com.miui.bugreport.jpg

[LordBredit]

I fixed crashes by adding the same values to all objects that were in the same group as well. So if you have the same problem, so just make sure that all your objects in your groups has same number of values

[defisym]

@Fernando

in Values.CRVal, line 102:

    public CValue getValue(int n)
    {
		if (rvValues[n]==null)
		{
            rvValues[n]=new CValue();
		}
		return rvValues[n];
    }

line 104 will throw exception when n is greater than 26 while using 'unlimited alterable values' before setting it, as android only read value numbers in cob, defined in edittime.

A quick fix is adding check before retrieving, and copy old values to re-allocated one, just like realloc in Cpp:

    public CValue getValue(int n) {
		if(n >= rvValues.length){
			// int oldLength = rvValues.length;
			// CValue[] oldValues = rvValues;

			// rvValues = new CValue[n];

			// // Copy old values, equals to realloc
			// System.arraycopy(oldValues, 0, rvValues, 0, oldLength);

			// or...
	            extendValues(n);
		}

//		if (rvValues[n]==null)
//		{
//		    rvValues[n]=new CValue();
//		}

		return rvValues[n];
    }

the same fix is also need in getString, etc.

[Fernando]

Thanks for the info, i will check asap

[Fernando]

@Fernando

in Values.CRVal, line 102:

    public CValue getValue(int n)
    {
        if (rvValues[n]==null)
        {
            rvValues[n]=new CValue();
        }
        return rvValues[n];
    }

line 104 will throw exception when n is greater than 26 while using 'unlimited alterable values' before setting it, as android only read value numbers in cob, defined in edittime.

A quick fix is adding check before retrieving, and copy old values to re-allocated one, just like realloc in Cpp:

    public CValue getValue(int n) {
        if(n >= rvValues.length){
            // int oldLength = rvValues.length;
            // CValue[] oldValues = rvValues;

            // rvValues = new CValue[n];

            // // Copy old values, equals to realloc
            // System.arraycopy(oldValues, 0, rvValues, 0, oldLength);

            // or...
                extendValues(n);
        }

//        if (rvValues[n]==null)
//        {
//            rvValues[n]=new CValue();
//        }

        return rvValues[n];
    }

the same fix is also need in getString, etc.

I don't get any crash by adding in values outside the index range. what version is this?, please post a small example.

i tested by doing

* User clicks with left button on Active
Active : Add 1 to Alterable Value(50)
objectvalue : Set Counter to AltValN( "Active", 50 )
Special : Add 4 to Global Value(60)
global : Set Counter to Global Value(60)

[defisym]

I don't get any crash by adding in values outside the index range. what version is this?, please post a small example.

i tested by doing

* User clicks with left button on Active
Active : Add 1 to Alterable Value(50)
objectvalue : Set Counter to AltValN( "Active", 50 )
Special : Add 4 to Global Value(60)
global : Set Counter to Global Value(60)

his screenshot shows that exception throws from EXP_EXTVAR.java, line 42 didn't extend array before getting values, unlike other classes.
(I don't know exactly what this is in event editor so I cannot post a mfa, maybe @LordBredit can share more info)

CND_CHOOSEVALUE.java line 56 & CND_CHOOSEVALUE_Old.java line 57 didn't extend also, which may cause the crash.

[Fernando]

Thanks @defisym, please @LordBredit need you to post a small mfa to check this.