FloodTolerance / Blocking questions

[Tuna]

From the OINC_Server.ini:

; Set this to the number of milliseconds that should be added to the timer for each IP
; address with each connection to the server (default: 500)
FloodGain=500

; Set this to the maximum number of milliseconds that may be on the timer and the
; connection still allowed (default: 1500)
FloodTolerance=1500

; Set this to the number of milliseconds that should be added to the timer for each IP
; address with each attempted connection when the tolerance has been reached (default: 10000)
FloodBlock=10000

I'm not sure, but I believe what this means is that, if the "timer" reaches 15 seconds and the user is still connected, they should be disconnected? Or is this intended to do something else? I know there is documentation to be released in the future, but if you guys have time to clarify the intention on this, I would be thankful for it.

[Looki]

I don't know, but 1000 milliseconds are 1 second, not 10 (=> 1500 ms = 1.5 s).

[James]

If you change FloodGain to 0 it should disable flood blocking - see if that fixes the random disconnections while I review the flood blocking code..

[Tuna]

Looki: yeah, thanks for pointing that out... I knew that, but I'm apparently getting old and can't do simple math anymore.

Jamie: I'll try that at lunch time in a few hours, thanks

[James]

New version uploaded that should fix the disconnection bug, but here's a quick explanation:

Every IP address has a timer in the server, which loses 1 every millisecond until it reaches 0. If FloodGain is 500, then every time the server receives a connection from an IP address, the timer gains another 500 milliseconds. If the timer gets higher than FloodTolerance, any connections from the IP address will be denied and the timer increased by the amount specified in FloodBlock, effectively banning flooding IP addresses for a few minutes.

To reach a FloodTolerance of 1500, the client would need to connect 4 times very quickly (as a FloodGain of 500 for the first connection will reset to 0 after 500 milliseconds).

[Tuna]

Interesting...

Flooding then is attempting to make too many connections, and has nothing to do with the amount of data being passed via the connection.

Initially, I took this to be more related to amounts of data, rather than the number of connections.

Joining / Leaving Channels doesn't affect this then, right?

[James]

No, only connecting or disconnecting.

[Tuna]

Also, still getting stray characters in the Channel_Name$

[James]

Really? Hrm.. I'll look into it.

[Tuna]

its intermittent...