Request for useless call to be removed

[Phi]

Hey,
I'd just like to request a call to GetPropValue() before querying the correct GetPropCheck() be removed from MMF2. I understand checkbox is a sub-property of other types, but this occurs, when it shouldn't, for checkbox-only properties (PROPTYPE_LEFTCHECKBOX).
Peacin' out, Φ

[James]

What problem does this cause?

[Phi]

It seems ineffective, and in extensions that have no Prop setting for properties like this, it could cause a crash.
In the DarkEDIF SDK, GetPropValue() calls to checkbox-only properties are currently treated as an invalid request, causing a error dialog, as there is no value associated with the property.
The checkbox value is stored the same way as any other property with a checkbox subproperty, separate from the original value. In code, it's something like this:

struct AnyPropertyType {
Prop * Value;
bool Checkbox; // MainValues is NULL for LEFTCHECKBOX, only this is used
};

From a black/white perspective, there's no problem, I can still code it to ignore those IDs, if it's that difficult to edit MMF2's side.

[LB]

I can confirm the call to GetPropValue for checkbox properties.

@Phi: I'm not sure how it would cause a crash or freeze with what you're doing - worst case scenario it isn't very efficient because of the useless call, but it's only the properties - they don't need to be very efficient.

[Phi]

That was worse case scenario, honestly I'd be surprised if any part of my code could crash. I do a lot of checks.